Skip to content
Snippets Groups Projects
bones_was_here's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

Compilers and other toolchain components should be backwards-compatible whenever possible otherwise they harm and frustrate their users. If a mappe...

Thomas Debesse's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

So, I re-read everything from the beginning, and it's funny to read I was right when I said:...

Thomas Debesse's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

@Garux, I simply want to lower the pressure and return back to the basics....

Thomas Debesse's avatar
closed issue #195 "Brushes being wrongly fused at compilation time" at Xonotic / NetRadiant
Thomas Debesse's avatar
commented on issue #195 "Brushes being wrongly fused at compilation time" at Xonotic / NetRadiant

Fixed by !211 (merged)

Garux's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

Here we go again 🤦🏿‍♀️...

Thomas Debesse's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

@Garux Actually I don't get why you go the conflict way while I'm just bringing help....

Thomas Debesse's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

metro sc shows specially tweaked light with adjusted backsplash via shader...

Thomas Debesse's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

To be honest, I didn't check every official Xonotic map one by one with the new backsplash algorithm, but after noticing visual glitches in a few ...

Spike29's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

Xonotic maps only identified 2 maps out of 30 that are not glitchy when using the new algorithm. That's only 6% of success!...

Garux's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant
metro sc shows specially tweaked light with adjusted backsplash via shader...
Thomas Debesse's avatar
  • 89a81105 · q3map2: do not use the new area light backsplash algorithm by Jelva...
Thomas Debesse's avatar
commented on issue #195 "Brushes being wrongly fused at compilation time" at Xonotic / NetRadiant

...

Thomas Debesse's avatar
commented on merge request !210 "q3map2: do not use the new area light backsplash algorithm by Jelvan by default, make it optional" at Xonotic / NetRadiant

So, the option is now -backsplashmode and takes 0 (point light as backsplash light) or 1 (area light as backsplash light)....

Thomas Debesse's avatar
Thomas Debesse's avatar
deleted branch illwieckz/fix-brush-fusing at Xonotic / NetRadiant
Thomas Debesse's avatar
pushed to branch master at Xonotic / NetRadiant
Thomas Debesse's avatar
accepted merge request !211 "q3map2: import fused brush fix from NRC" at Xonotic / NetRadiant
Thomas Debesse's avatar
pushed to branch illwieckz/fix-brush-fusing at Xonotic / NetRadiant
  • b454be68 · q3map2: import fused brush fix from NRC
Thomas Debesse's avatar
commented on issue #195 "Brushes being wrongly fused at compilation time" at Xonotic / NetRadiant

I also confirm this fixes the bug when compiling the metro map.