Skip to content
Snippets Groups Projects

Fix ambient occlusion artifact

Merged robojumper requested to merge robojumper/veloren:ao-artifact-fix into master
1 unresolved thread

As suggested by @zesterer, maps both 1 and 2 neighbors to the same occlusion value.

Also, apparently VS Code creates new files with CRLF line endings by default. Changed my settings and reformatted the file.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
18 .map(|v| !v.is_empty())
19 .unwrap_or(false),
20 vol.get(pos + offs[1])
21 .map(|v| !v.is_empty())
22 .unwrap_or(false),
23 );
24
25 if s1 && s2 {
26 0.0
27 } else {
28 let corner = vol
29 .get(pos + offs[0] + offs[1])
30 .map(|v| !v.is_empty())
31 .unwrap_or(false);
32 // Map both 1 and 2 neighbors to 0.5 occlusion
33 if [s1, s2, corner].iter().any(|t| *t) {
  • robojumper added 2 commits

    added 2 commits

    Compare with previous version

  • @robojumper In the future, could you branch off the main repo instead of working in your fork? That way, the CI will run on our up to date system. Thanks :smiley:

  • Forest Anderson mentioned in commit 782e7594

    mentioned in commit 782e7594

  • Please register or sign in to reply
    Loading