[bifrost] Keygen Retries and ChurnRetryInterval Mimir

Resolves #1585 (closed) - will separate out the seed refresh component noted on a comment there into a separate issue after this since it will also require more changes in go-tss. This is just a draft and has seen no testing, just pushing for now in case someone wants to carry the torch, otherwise will continue with this testing next week.

This has been tested with paths noted in comment below. Also this was extended to read a mimir for the ChurnRetryInterval.

bifrost/signer/sign.go

@@ -363,7 +363,7 @@ func (s *Signer) scheduleRetry(keygenBlock ttypes.KeygenBlock) bool {
 	if churnRetryInterval <= 0 {
 		churnRetryInterval = constants.NewConstantValue().GetInt64Value(constants.ChurnRetryInterval)
 	}
-	keygenRetryInterval, err := s.thorchainBridge.GetMimir("KeygenRetryInterval")
+	keygenRetryInterval, err := s.thorchainBridge.GetMimir(constants.KeygenRetryInterval.String())
 	if err != nil {
 		s.logger.Error().Err(err).Msg("fail to get keygen retries mimir")
 		return false
@@ -372,6 +372,16 @@ func (s *Signer) scheduleRetry(keygenBlock ttypes.KeygenBlock) bool {
 		return false
 	}
 
+	// sanity check the retry interval is at least 1.5x the timeout
+	retryIntervalDuration := time.Duration(keygenRetryInterval) * constants.ThorchainBlockTime
+	if retryIntervalDuration <= s.cfg.KeygenTimeout*3/2 {
+		s.logger.Error().
+			Dur("retryInterval", retryIntervalDuration).
+			Dur("keygenTimeout", s.cfg.KeygenTimeout).
+			Msg("retry interval too short")
+		return false
+	}
+
 	height, err := s.thorchainBridge.GetBlockHeight()
 	if err != nil {
 		s.logger.Error().Err(err).Msg("fail to get last chain height")