Skip to content
Snippets Groups Projects

[bifrost] Keygen Retries and ChurnRetryInterval Mimir

Merged Ursa (9R) requested to merge ursa/keygen-retry into develop

Resolves #1585 (closed) - will separate out the seed refresh component noted on a comment there into a separate issue after this since it will also require more changes in go-tss. This is just a draft and has seen no testing, just pushing for now in case someone wants to carry the torch, otherwise will continue with this testing next week.

This has been tested with paths noted in comment below. Also this was extended to read a mimir for the ChurnRetryInterval.

Edited by Ursa (9R)

Merge request reports

Merge request pipeline #1001718419 passed

Merge request pipeline passed for 47c383bd

Test coverage 53.50% (-0.10%) from 1 job
Deployed to integ‎ration‎ 1 year ago
Approved by

Merged by Son of OdinSon of Odin 1 year ago (Sep 14, 2023 1:22pm UTC)

Merge details

  • Changes merged into develop with 7da342fa (commits were squashed).
  • Deleted the source branch.

Pipeline #1004398689 failed

Pipeline failed for 7da342fa on develop

Test coverage 53.50% (-0.10%) from 1 job
Deployed to integ‎ration‎ 1 year ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Ursa (9R)

      :pray:

      (I echo the earlier thought that testing should ideally include whether a Ready node is able to (/fully) unbond after a keygen failure and then become an Active node on a keygen retry.)

  • Ursa (9R) added 19 commits

    added 19 commits

    Compare with previous version

  • Author Maintainer

    Mocknet Testing:

    • No keygen retry configured in mimir
      • Failed with one offline node, TssPool failures reported as expected
      • Offline node restarted, succeeded on next churn retry
    • Keygen retry configured
      • Failed with one offline node, retried until within interval blocks of next churn retry, TssPool failures reported after retries exhausted
      • Failed with one offline node, retried until offline node enabled, next retry was successful, TssPool success reported
      • When offline node came back online and there were 2 keygen blocks since last online it still tries the first one (old keygen block with other nodes moved on), but this is consistent with current behavior and should not cause new unintended side effects
  • Ursa (9R) marked this merge request as ready

    marked this merge request as ready

  • Ursa (9R) changed title from Draft: [bifrost] Keygen Retries to [bifrost] Keygen Retries and ChurnRetryInterval Mimir

    changed title from Draft: [bifrost] Keygen Retries to [bifrost] Keygen Retries and ChurnRetryInterval Mimir

  • Ursa (9R) changed the description

    changed the description

  • Author Maintainer

    Would appreciate @son-of-odin / @heimdallthor review in case of any gotchas.

  • Heimdall
  • Heimdall
  • Heimdall
  • Heimdall
  • Ursa (9R) added 3 commits

    added 3 commits

    • 8113fb44 - 1 commit from branch develop
    • 687a72be - [bifrost] Keygen Retries and ChurnRetryInterval Mimir
    • 0e0ae1be - heimdall feedback

    Compare with previous version

  • Ursa (9R) added 1 commit

    added 1 commit

    Compare with previous version

  • changed milestone to %Release-1.121.0

  • Ursa (9R) added 1 commit

    added 1 commit

    Compare with previous version

  • Ursa (9R) added 5 commits

    added 5 commits

    Compare with previous version

  • Ursa (9R) added 4 commits

    added 4 commits

    Compare with previous version

    • Resolved by Multipartite

      be aware of the slashing that occurs, which is 6 hours of yield (i think). If you're doing retry, then that slashing amount should prob be reduced to match the retry interval

  • Ursa (9R) added 9 commits

    added 9 commits

    Compare with previous version

  • Ursa (9R) added 1 commit

    added 1 commit

    • 48b07306 - add retry to keygen broadcast, remove dead backoff config

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading