Skip to content
Snippets Groups Projects

[feature] Circuit Breaker

Merged Son of Odin requested to merge circuit-breaker into develop

This contains 1/2 of the circuit breaker. The change here is that if we mint more than the max supply of rune, burn some rune from the reserve to restore the supply at 500m.

The second part is pausing opening of loans in this scenario.

Code Walkthrough https://www.youtube.com/watch?v=e6gZ77DdMrc

Edited by Son of Odin

Merge request reports

Merge request pipeline #878391623 passed

Merge request pipeline passed for 5c2cec69

Test coverage 54.90% (0.10%) from 1 job
Deployed to integ‎ration‎ 1 year ago
Approved by

Merged by Son of OdinSon of Odin 1 year ago (May 26, 2023 8:20am UTC)

Merge details

  • Changes merged into develop with 595fe65a (commits were squashed).
  • Deleted the source branch.

Pipeline #879897799 passed

Pipeline passed for 595fe65a on develop

Test coverage 54.90% (0.10%) from 1 job
Deployed to integ‎ration‎ 1 year ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • akrokr
  • Son of Odin added 1 commit

    added 1 commit

    Compare with previous version

  • Ursa (9R)
    • Resolved by Son of Odin

      I was for some reason under the impression that the idea of the circuit breaker was to just fail the mint in the transaction once we hit the cap instead of burning the reserve to rectify it, was that never on the table? If that were the case it would force savers and borrowers to assume the risk of their deposit getting stuck and having to wait until a better time. If we burn the reserve then RUNE holders and nodes subsidize impatient users, and I'm unsure how I feel about that.

  • Ursa (9R) mentioned in merge request !2713 (merged)

    mentioned in merge request !2713 (merged)

  • Pluto changed milestone to %Release-1.104.0

    changed milestone to %Release-1.104.0

  • Son of Odin added 19 commits

    added 19 commits

    Compare with previous version

  • Son of Odin added 1 commit

    added 1 commit

    Compare with previous version

  • Son of Odin added 1 commit

    added 1 commit

    Compare with previous version

  • Son of Odin added 2 commits

    added 2 commits

    Compare with previous version

  • Son of Odin added 1 commit

    added 1 commit

    Compare with previous version

    • Resolved by Ursa (9R)

      I would still personally prefer skipping the reserve burn and just allowing the inflation, but sounds like in discussion that I missed everyone came to agreement on the reserve burn so I defer to the consensus - code LGTM.

  • Ursa (9R) approved this merge request

    approved this merge request

  • Pluto changed milestone to %Release-1.105.0

    changed milestone to %Release-1.105.0

  • removed milestone %Release-1.105.0

  • Maintainer

    on the same page as @ursa9r, code looks good, if consensus is to burn, i'll smash approve

  • akrokr changed milestone to %Release-1.107.0

    changed milestone to %Release-1.107.0

  • As a policy going forward we should document discussions/consensus about major economic changes like this on the PR.

    Can someone please copy/paste the relevant discussion where a quorum was reached on this?

  • removed milestone %Release-1.107.0

  • mentioned in issue #1501 (closed)

  • Son of Odin added 79 commits

    added 79 commits

    Compare with previous version

  • Son of Odin added 1 commit
  • Son of Odin added 1 commit

    added 1 commit

    Compare with previous version

  • changed milestone to %Release-1.108.0

  • Ursa (9R) approved this merge request

    approved this merge request

  • Multipartite
  • Son of Odin added 1 commit

    added 1 commit

    • 31e7bc01 - agreeing to this change for the following reason.

    Compare with previous version

  • Ursa (9R) approved this merge request

    approved this merge request

  • akrokr
  • Son of Odin added 1 commit

    added 1 commit

    • 93afdddd - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Son of Odin added 1 commit

    added 1 commit

    • 9624619b - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ursa (9R) approved this merge request

    approved this merge request

  • Multipartite mentioned in merge request !2851 (closed)

    mentioned in merge request !2851 (closed)

  • Pluto changed milestone to %Release-1.109.0

    changed milestone to %Release-1.109.0

  • Contributor

    Please rebase for 1.109.0

  • Son of Odin added 1 commit

    added 1 commit

    Compare with previous version

  • Son of Odin added 17 commits

    added 17 commits

    Compare with previous version

  • Multipartite added 13 commits

    added 13 commits

    Compare with previous version

  • Multipartite added 1 commit

    added 1 commit

    • 5b0fcbe4 - Network version 1.108.0 -> 1.109.0

    Compare with previous version

  • Son of Odin added 18 commits

    added 18 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading