Skip to content

Build: Resto is incompatible with cohttp-lwt.5.1.0

Pierre Boutillier requested to merge nomadic-labs/tezos:cohttp_5.1_stream into master

Context

Octez-node leaks a file descriptor for each never ending streaming RPC opened...

Needs opam-repository!426 (merged)

Manually testing the MR

  • Start a node in sandbox
  • get its pid and do ls /proc/PID/fd | wc -l to get the number of opened fd
  • fire any command with octez-client that waits for the inclusion of an operation. For example, octez-client transfer 1 from bootstrap4 to bootstrap3
  • do ls /proc/PID/fd | wc -l and read that it increased by one
  • redo X time the octez-client command. See that ls /proc/PID/fd | wc -l increased of X...

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Pierre Boutillier

Merge request reports