Skip to content

fix monitor_operation filtering by validation passes

Albin Coquereau requested to merge albin@fix-5568 into master

Context

validation_passes argument for pending_operations and monitor_operations was introduced in !6724 (merged). But only operation already in the mempool were filtered for monitor_operations. The operations that arrived after the RPC call were not filtered. This MR fixes #5568 (closed) that reported this issue.

Manually testing the MR

Run a node in sandboxed or connected to a network and try:

curl -s http://<node_rpc_addr>/chains/main/mempool/monitor_operations\?validation_pass\=3

Only manager operations should be displayed.

Checklist

  • n/a Document the interface of any function added or modified (see the coding guidelines)
  • n/a Document any change to the user interface, including configuration parameters (see node configuration)
  • n/a Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Diane Gallois-Wong

Merge request reports