Skip to content

Manifest: fix pretty-printing of s-exprs

Romain requested to merge nomadic-labs/tezos:romain-manifest-fix into master

Context

Fix a bug in the pretty-printing of s-expressions that do not end with E.

Manually testing the MR

Add this to manifest/manifest.ml below let of_atom_list:

  let () = pp Format.std_formatter [ S "l" :: S "a" ]

Before this MR this would print (la), which is incorrect. After this MR this prints (l a), which is correct.

Interestingly [ S "l" :: S "a" :: E ] would work.

Please also check that no existing dune file is modified by make -C manifest.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports