Skip to content

introduce encoding_with_legacy_attestation_name functions in environment

Context

This MR introduce encoding_with_legacy_attestation_name functions in the environment and use them in the shell

Depends on !8531 (merged)

Manually testing the MR

To manually testing this MR you can compare RPCs outputs with and without legacy attestation name. You can apply the following patch to use the protocol encoding using attestation instead of endorsement.

The RPCs using this encoding in JSON (such as mempool/pending_operation or blocks/<block>/operations/1) should output attestation as a kind of operation instead of endorsement. Compare this outputs without and without the patch to show that the default encoding is still the legacy one.

test_encoding.patch

Checklist

  • n/a Document the interface of any function added or modified (see the coding guidelines)
  • n/a Document any change to the user interface, including configuration parameters (see node configuration)
  • n/a Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Albin Coquereau

Merge request reports