Skip to content

SCORU/Node: fix fuel limited feed input of PVM

Alain Mebsout requested to merge alain@functori@fix-fueled-eval into master

Context

The rollup node incorrectly limits the execution of the PVM when we feed it an input. It used to set the input (and continue evaluation) even if it was not able to reach a point where it required an input. In some cases (during dissections) the rollup node can ignore inputs because it has enough fuel to set the input but not to evaluate the PVM. This scenario is more likely to happen in the Arith PVM where input consumption is interleaved with actual PVM computations (while in the WASM PVM, all inputs are saved in the state at the beginning of the inbox interpretation).

This can lead the rollup node to compute incorrect dissections.

This MR fixes this behavior by making the eval function return a status to indicate if it was aborted due to a lack of fuel.

Manually testing the MR

Merge request reports