Skip to content

Makefile: set [OCTEZ_EXECUTABLES] in target [enable-time-measurement]

Context

Added in !6957 (merged), the variable OCTEZ_EXECUTABLES must be set when calling the target build. Indeed, this target should rarely be called directly, instead the targets all, (experimental-)release, static should be used. The target enable-time-measurement builds with time-measurement instrumentation enabled. This target calls build directly without setting OCTEZ_EXECUTABLES. As a result of !6957 (merged), this now triggern a make error.

In this MR, I change the target enable-time-measurement to call the target all instead. This ensures that OCTEZ_EXECUTABLES is set. Note that PROFILE is set to dev by default and does not have to be set explicitly, therefore I removed that as well.

Manually testing the MR

run make enable-time-measurement before and after this MR.

Not sure how to check that the instrumentation is actually applied, but you can change the recipe in the target all to env instead and observe that the environment variable DUNE_INSTRUMENT_WITH is properly set.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Arvid Jakobsson

Merge request reports