Skip to content

SCORU: Require conflicting commitments hashes to start game

Yann Regis-Gianas requested to merge yrg@scoru@offchain-conflict-points into master

Context

Since get_conflict_point is not gas friendly, we stop using it in the protocol when we start a game. This computation must be done off-chain.

Related to #4372 (closed). This MR partially fixes the issue of gas-unfriendly linear traversals.

TODO:

  • add tests (negative & storage)
  • rebase + backport

Manually testing the MR

CI

owner: @sribaroud

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Sylvain R.

Merge request reports