Context

Changes:

The skip list is initialized with init_witness including only a Start_of_level payload.
Sc_rollup_add_messages (and internal transfers to sc_rollup) no longer modify the inbox, only the internal witness, the inbox is removed from the operation's result.
The inbox and witness are automatically updated at the finalization of the block, removing the need to wait for the next level to archive the messages.

Next actions:

I broke even more the field nb_messages_in_commitment_period because we are removing it in the next merge request while closing: #3978 (closed)
Removed the out-dated benchmarks for Sc_rollup_add_messages, @sribaroud will be able to redo the gas-model while closing #3292 (closed), it should be much easier

Manually testing the MR

Document the interface of any function added or modified (see the coding guidelines)
n/a Document any change to the user interface, including configuration parameters (see node configuration)
Provide automatic testing (see the testing guide).
n/a For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
Select suitable reviewers using the Reviewers field below.
Select as Assignee the next person who should take action on that MR

Edited Nov 28, 2022 by Valentin Chaboche