Skip to content

Include operations from external pool in received order

Context

Fix #2866 (closed): when using an external operations pool, there was no guarantee which operations would be included in the block. This fix makes sure that operations are considered for inclusion in the order they are received from the external pool.

I have added some tests for this feature but also remove 1 test in baking.ml.

The removed test was indirectly relying on the external pool being unordered and cannot be replaced by using a regular mempool. It is only commented out at this point since we might want to reintegrate it further down the road.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Richard Bonichon

Merge request reports