Skip to content

Proto/bench: add ADX check to BLS benchmarks

Context

(Repost of !4596 (merged))

This MR adds a check for BLS benchmarks that ensures that the BLS library has been compiled in a specific way that ensures that the benchmarks remain accurate.

Manually testing the MR

  • Compile the project: make build-dev-deps; make
  • All BLS benchmarks should fail for Snoop, for instance try ./tezos-snoop benchmark N_IAdd_bls12_381_g2_alpha and save to tmp.workload.
  • Uninstall BLS: opam uninstall bls12-381
  • Rebuild BLS with the correct environment variable: BLST_PORTABLE=y opam install bls12-381-unix
  • Recompile
  • All BLS benchmarks can now run properly

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports

Loading