Proto,tx_rollup: Consider the size of the message in the rejection
Context
There is an issue in a corner case of the rejection operation of TORU that basically makes it possible for an attacker to publish a message for which one cannot provide a “large enough” proof, and that can be used by the same attacker to publish a wrongful commitment that cannot be refuted. This is a deal breaker for the TORU feature as a whole, but it does not endanger the safety of the layer-1.
This simple fix addresses the issue.
Manually testing the MR
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rst
for the protocol and the environment,CHANGES.rst
at the root of the repository for everything else). -
Select suitable reviewers using the Reviewers
field below. -
Select as Assignee
the next person who should take action on that MR
Edited by Valentin Chaboche