Skip to content

Proto: make Destination a polymorphic variant (SCORU)

Mehdi Bouaziz requested to merge mehdi@destination_polyvar into master

Context

This MR transforms Contract.t variant into a polymorphic variant, as well as Destination.t, now defined as an extension of Contract.t rather than a wrapper (yummy subtyping!). It also exposes the constructors of Contract.t which didn't need to be abstract.

This is as first step towards: adding new destinations and specializing internal operations, both wanted for SCORU.

Manually testing the MR

🐫

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Mehdi Bouaziz

Merge request reports