Skip to content

Manifest: cleanup related to JS

Hugo Heuzard requested to merge nomadic-labs/tezos:hhugo-manifest-js into master

Context

Change the implementation of our node wrapper. The previous implementation was not working for inline tests requiring the node wrapper.

  • use the binaries field from the env stanza to override the node binary.
  • use an environment variable to communicate the javascript libraries to preload as we no longer have access to the flags passed to node.
  • our wrapper needs to be able to execute the real node program but dune will shadow it with our wrapper instead, we save (before shadowing) and restore (inside our wrapper) the PATH environment variable to work around the issue.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Hugo Heuzard

Merge request reports