Manifest: bin_tx_rollup_node
Note to the reviewers
@romain.nl is a co-author to this MR, and as such he is ineligible to approve it. Nevertheless, I have added him as a reviewer as he can provide valuable insight.
Context
This MR updates the dune and OPAM files of the bin_tx_rollup_node executable by using the manifest generator. The main goal of the manifest generator is to fully represent and auto-generate all the dune and opam files using common organizational patterns and formatting. In other words, the main changes introduced in this PR should be fully equivalent with the master branch.
Furthermore, it should be noted that the way in which the manifest generator emits dependencies is markedly more explicit than the style which we have been following in many of the dune files. Therefore, it is expected that many of the libraries and executables will have changes to the library dependencies. This is normal(!) and the changes are expected to be fully equivalent to what was previously specified. Of course, please be encouraged to scrutinize the changes for anything we may have missed.
Manually testing the MR
The diff as is shown using conventional diff tools (including the diff here on GitLab) is unfortunately not easy to read. However, we have built a tool to help review the changes. You can run the following commands to get the tool and compare this branch against master.
# Checkout this branch
git checkout richard-bin-tx-rollup-node
# Get a copy of the diff tool locally
git checkout richard-manifest-protos manifest/diff
# Run the diff tool on all the dune and opam files against the master branch
dune exec manifest/diff/main.exe -- master HEAD $(find src -name dune -o -name '*opam') | less -R
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rstfor the protocol and the environment,CHANGES.rstat the root of the repository for everything else). -
Select suitable reviewers using the Reviewersfield below. -
Select as Assigneethe next person who should take action on that MR}