Skip to content

Avoid using globals return and fail prefer locals (protos)

Context

Part of !4742 (merged)

Continuation of !4716 (merged) (merged) (merged) (merged) (merged)

This is in preparation to move some of the globals (return along with ok and the infix binders) into a separate namespace.

The main idea is to prevent modules which have already been converted (where the legacy globals and infix namespace is not open) to revert to it accidentally.

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports