Manifest (9): proxy libs, lib_client_base_unix, lib_benchmark

This is a small subset of !3366 (merged), which aims at generating dune and .opam files from a manifest.ml file. See !3366 (merged) for a broad view of the end goal.

Because !3366 (merged) is too large to review in one go, the plan is to make several MRs targetting subparts of the dune and .opam files, without the generator itself. The goal is to check all changes in dune and .opam files made by !3366 (merged). Even if we do not merge !3366 (merged) ever, we'll fix some inconsistencies between dune and .opam files this way. After all changes to dune and .opam files have been reviewed and merged, we can merge the generator itself and easily see that it generates the exact same files.

This MR contains the subset of !3366 (merged) for:

• lib_proxy
• lib_proxy_server_config
• lib_client_base_unix
• lib_benchmark

The changes are mostly about whitespace and fixing dune-opam consistency, as well as using conventions that are used elsewhere.

Review Tips

I left comments to explain some of the changes. Unfortunately GitLab will not always show those comments as you read the files :( So I invite you to read those comments before reviewing.

Also, patdiff helps a lot, as well as the -w option of git diff. You can use patdiff with git diff as follows:

opam install patdiff
export GIT_EXTERNAL_DIFF=`pwd`/_opam/bin/patdiff-git-wrapper

If you read the diff in GitLab, the -w option of git diff can be activated by opening preferences (the gear icon while reviewing) and unchecking "show whitespace changes".

Apparently, VS Code is also very nice to review whitespace diffs.

Manually testing the MR

Compile everything (or let the CI do it for you).

Checklist

• Select suitable reviewers using the Reviewers field below.
• Select as Assignee the next person who should take action on that MR