Skip to content

Manifest (2): lib_crypto, lib_error_monad, lib_rpc, lib_hacl_glue

Romain requested to merge nomadic-labs/tezos:romain-manifest-step-2-opam into master

Context

This is a small subset of !3366 (merged), which aims at generating dune and .opam files from a manifest.ml file. See !3366 (merged) for a broad view of the end goal.

Because !3366 (merged) is too large to review in one go, the plan is to make several MRs targetting subparts of the dune and .opam files, without the generator itself. The goal is to check all changes in dune and .opam files made by !3366 (merged). Even if we do not merge !3366 (merged) ever, we'll fix some inconsistencies dune and .opam files this way. After all changes to dune and .opam files have been reviewed and merged, we can merge the generator itself and easily see that it generates the exact same files.

This MR contains the subset of !3366 (merged) for:

  • lib_crypto
  • lib_error_monad
  • lib_rpc
  • lib_hacl_glue

Review Tips

I left comments to explain some of the changes. Unfortunately GitLab will not always show those comments as you read the files :( So I invite you to read those comments before reviewing.

Also, patdiff helps a lot, as well as the -w option of git diff. You can use patdiff with git diff as follows:

opam install patdiff
export GIT_EXTERNAL_DIFF=`pwd`/_opam/bin/patdiff-git-wrapper

Manually testing the MR

Compile everything (or let the CI do it for you).

Checklist

  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Romain

Merge request reports