Draft: CIAO: remove ?dependent
What
This MR removes the ?dependent argument of make_rules in ci/bin/code_verification.ml.
Why
All it does is ensure that jobs only start if the previous stage succeeded. But we don't actually want to wait for previous stages; it's better to start jobs as soon as possible (while still protecting most jobs behind job_start).
How
One issue is that jobs in the images stage actually need to wait for the previous stage to finish. Otherwise, jobs that build images would start immediately, without waiting for job_start. And we cannot define those jobs with job_start in scope yet. Also, even with job_start in scope, we need the pipeline_type to decide whether to depend on job_start or not. So those jobs still need to be Staged. But since those jobs are not defined using make_rules, we don't care.
Manually testing the MR
See Pipeline #2034497294 which only automatically started the sanity jobs (unless someone clicked on trigger since then :p ).
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rstfor the protocol and the environment,CHANGES.rstat the root of the repository for everything else). -
Select suitable reviewers using the Reviewersfield below. -
Select as Assigneethe next person who should take action on that MR