Baker: Deprecation warning regarding absence of --without-dal option

What

Port the --without-dal option to Paris and Quebec protocol. For those, we currently only raise a deprecation warning if the option is not used.

Why

Discussion while merging !16049 (merged) raised a concern about the fact that several users do for p in $protocol do octez-baker-$p --options in their launching scripts and this line is not valid if different protocols do not accept the same options, hence the modification of Paris and Quebec protocol to support this option, without making it mandatory.

How

Simply porting what had been done in !16049 (merged) but raising a warning rather than failing if a baker daemon is launched without mentions of DAL.

Manually testing the MR

In a first terminal run

make
./src/bin_node/octez-sandboxed-node.sh 1 --connections 0

Open another terminal and run

eval `./src/bin_client/octez-init-sandboxed-client.sh 1`
octez-activate-alpha
octez-baker-alpha run with local node /tmp/tezos-node.*/ >> /tmp/log_$(date "+%Hh%M") 2>&1

It fails with

Error:
  Please connect a running DAL node using '--dal-node <endpoint>'. If you do not want to run a DAL node, you have to opt-out using '--without-dal'.

If you run instead

eval `./src/bin_client/octez-init-sandboxed-client.sh 1`
octez-activate-021-PsQuebec
octez-baker-PsQuebec run with local node /tmp/tezos-node.*/ >> /tmp/log_$(date "+%Hh%M") 2>&1

you should get this new warning:

Jan 14 15:56:33.017: DEPRECATED: Please use a DAL node to launch a baker. If you purposely do not
Jan 14 15:56:33.017:   run a DAL node, the option --without-dal will soon be mandatory.
Node is bootstrapped.

Adding the --without-dal option generates following warning, both for alpha and Quebec:

Jan 14 15:57:17.078: No DAL node endpoint has been provided.
Jan 14 15:57:17.078: It will soon be required to launch a
Jan 14 15:57:17.078:   DAL node before running the baker. For instructions on running a DAL node,
Jan 14 15:57:17.078:   please visit https://docs.tezos.com/tutorials/join-dal-baker.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Guillaume Genestier

Merge request reports

Loading