scripts/proto_manager: Fix rehash

Mathias Bourgoinrequested to merge
mb@proto_manager_fixes into master

What

This MR fixes the rehash command. It has already been used to produce the QuebecB MR snapshot !14695 (closed).

Most of the sed command calls (in rehash) are now replaced by a single function that replaces all necessary strings.

Why

How

Manually testing the MR

Here is what I do to check the results:

  • from master:
# cherry pick all QuebecB commits 
git cherry-pick 8fb8b550 0635edeb 22a1bc44 68f5f66d c9b7b947 82a2ad19 c9101300
# rehash QuebecA into QuebecB
./scripts/proto_manager.sh --hash --from 021_PsquebeC
## answer QuebecB, quebecb, y, 5856695454559796, y
## wait for the script to run
## compare the commits of the generated branche with those of the QuebecB snapshot branch (this can be scripted with `diff <(git show "$commit1") <(git show "$commit2")`)

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports