CI: move scripts from `.gitlab/ci/jobs` to `scripts/ci`
What
This MR moves all .sh
files from .gitlab/ci/jobs
to scripts/ci
.
Why
For consistency. The .gitlab/ci/jobs
folder no longer makes much sense with CIAO since all jobs are inlined in pipelines.
Before this MR, tree .gitlab/ci/jobs
looked like this:
.gitlab/ci/jobs
├── build
│ ├── bin_packages_deb_dependencies.sh
│ └── bin_packages_rpm_dependencies.sh
├── doc
│ └── documentation:manuals.sh
├── packaging
│ ├── build-debian-packages-dependencies.sh
│ └── build-debian-packages.sh
└── test
└── script:snapshot_alpha_and_link.sh
After this MR, .gitlab/ci/jobs
is empty and can be recursively deleted. Scripts have joined their friends in scripts/ci
.
I considered creating subdirectories in scripts/ci
but I think we would need to think about the folder hierarchy a bit longer before we do that, and I'm only adding 6 files in a directory with 62 so it's only a 10% increase.
How
With the power of:
git mv
-
git grep
to find all occurrences -
make -C ci
to apply changes
Manually testing the MR
All the jobs that were moved must still pass in the CI.
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rst
for the protocol and the environment,CHANGES.rst
at the root of the repository for everything else). -
Select suitable reviewers using the Reviewers
field below. -
Select as Assignee
the next person who should take action on that MR