Skip to content

Remove unseen and rejected slot header status + PATCH /commitments RPC

Raphaël Cauderlier requested to merge rafoo@dal_remove_patch_commitment_rpc into master

What

Stacked on !12880 (merged).

Remove the notions of unseen and rejected (aka. "not_selected") slot header, together with the PATCH /commitments RPC which sets the unseen status.

Why

The main motivation is to simplify the interface before changing the way we identify slots (using slot_id instead of commitments).

A user publishing a commitment can still check if its publication was rejected by comparing the commitment she attempted to publish and the one which got included.

How

Manually testing the MR

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Raphaël Cauderlier

Merge request reports