DAL/Slot manager: don't reconstruct if slot is already stored
What
Stacked on !12875 (merged).
Lookup the slot store before attempting a reconstruction in the GET /slot/pages/
RPC.
Why
Performance.
How
The function responsible for computing the slot is Slot_manager_legacy.get_slot
. In the first commit, we grant it access to the full store instead of only the shard part. In the second commit, we use this to try to read the slot from the slot store and only perform a reconstruction from the shards if the slot could not be obtained.
Manually testing the MR
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rst
for the protocol and the environment,CHANGES.rst
at the root of the repository for everything else). -
Select suitable reviewers using the Reviewers
field below. -
Select as Assignee
the next person who should take action on that MR
Edited by Raphaël Cauderlier