Skip to content

Setting head triggers proto table update

Victor Allombert requested to merge vicall@earlier_proto_table_update into master

This MR aims to update the protocol level table as soon as a block in stored (during set_head) so that the protocol table is updated before the new block is advertised as a new_head/new_block on the monitoring streams. It avoids an inconsistency, in the context of !9490 (merged) (%Non-blocking RPC feature as experimental) where the RPC process tries to read the newly advertised block that is not yet known in the protocol table -- resulting in a failure.

Manually testing the MR

Green CI

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR

Merge request reports