Skip to content

EVM: Record call stipend regardless if balance is enough

Hantang Sun requested to merge hantang@evm@record_call_call_regardless_of_balance into master

Context

Results from the evaluation test suite suggests that call-stipend applies even when the balance in not enough to cover transfer value.

Manually testing the MR

Run evaluation test suite. Number of failing test decrease from 28 to 23. Diff is below.

stMemExpandingEIP150Calls_NewGasPriceForCodesWithMemExpandingCalls_data_index_0_gas_index_0_value_index_0: Failure -> Success
stNonZeroCallsTest_NonZeroValue_CALL_ToNonNonZeroBalance_data_index_0_gas_index_0_value_index_0: Failure -> Success
stSpecialTest_eoaEmpty_data_index_1_gas_index_1_value_index_0: Failure -> Success
stNonZeroCallsTest_NonZeroValue_CALLCODE_ToNonNonZeroBalance_data_index_0_gas_index_0_value_index_0: Failure -> Success
stEIP150Specific_NewGasPriceForCodes_data_index_0_gas_index_0_value_index_0: Failure -> Success

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Hantang Sun

Merge request reports