EVM/Eval: Fixed a bug in parsing labels in evaluation
Context
I discovered this bug when attempting to fix buffer.json
in stMemoryTest
with @thomas.pecseli . The test suite keeps checking post conditions with label ok-f3
and fail-f3
when the label of the test is ok
or fail
. We tracked down the problem to parsing of label in deserialisation. r":label (\w+)"
was used as the regex (\w
is equivalent to [a-zA-Z0-9_]
) when the labels in a lot of tests contains -
. This MR changed the regex to r":label ([\w-]+)"
to account for the -
.
Unfortunately, with the fix the number of failing tests increase from 1618 to 1752(compatibility drop from 87.83% to 86.82%), likely due to additional check being enabled.
Manually testing the MR
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rst
for the protocol and the environment,CHANGES.rst
at the root of the repository for everything else). -
Select suitable reviewers using the Reviewers
field below. -
Select as Assignee
the next person who should take action on that MR