chore(telemetry): automagically instrument HTTP clients

As part of #621, we want to have insight across everything `dmd` does.

To automagically instrument our HTTP calls, we can use `otelhttp`'s
inbuilt automagic `http.Transport` for this.

This also improves the duplication by calling out to a central method
for creating our HTTP client.

cmd/dmd/cmd/db_generate_advisories.go

@@ -2,7 +2,6 @@ package cmd
 
 import (
 	"fmt"
-	"net/http"
 	"os"
 
 	"dmd.tanna.dev/internal/advisory"
@@ -47,7 +46,7 @@ Known issues:
 		sqlDB, err := openDatabaseForWrite(ctx, databasePath)
 		cobra.CheckErr(err)
 
-		httpClient := http.DefaultClient
+		httpClient := tracing.NewHTTPClient()
 
 		pw := view.NewProgressWriter(os.Stdout, noProgress)
 

cmd/dmd/cmd/db_generate_dependencyhealth.go

@@ -2,7 +2,6 @@ package cmd
 
 import (
 	"fmt"
-	"net/http"
 	"os"
 
 	"dmd.tanna.dev/internal/dependencyhealth"
@@ -39,7 +38,7 @@ Known issues:
 		sqlDB, err := openDatabaseForWrite(ctx, databasePath)
 		cobra.CheckErr(err)
 
-		httpClient := http.DefaultClient
+		httpClient := tracing.NewHTTPClient()
 
 		pw := view.NewProgressWriter(os.Stdout, noProgress)
 		go pw.Render()

cmd/dmd/cmd/db_generate_libyear.go

@@ -2,7 +2,6 @@ package cmd
 
 import (
 	"fmt"
-	"net/http"
 	"os"
 
 	"dmd.tanna.dev/internal/libyear"
@@ -37,7 +36,7 @@ Known issues:
 		sqlDB, err := openDatabaseForWrite(ctx, databasePath)
 		cobra.CheckErr(err)
 
-		httpClient := http.DefaultClient
+		httpClient := tracing.NewHTTPClient()
 
 		pw := view.NewProgressWriter(os.Stdout, noProgress)
 		go pw.Render()

cmd/dmd/cmd/db_generate_missingdata.go

@@ -2,7 +2,6 @@ package cmd
 
 import (
 	"fmt"
-	"net/http"
 	"os"
 
 	"dmd.tanna.dev/internal/depsdev"
@@ -37,7 +36,7 @@ Known issues:
 		sqlDB, err := openDatabaseForWrite(ctx, databasePath)
 		cobra.CheckErr(err)
 
-		httpClient := http.DefaultClient
+		httpClient := tracing.NewHTTPClient()
 
 		pw := view.NewProgressWriter(os.Stdout, noProgress)
 

cmd/dmd/cmd/import_scorecard.go

@@ -58,7 +58,7 @@ dmd db import scorecard --db dmd.db '*.json'
 		}
 		pw.AppendTracker(&tracker)
 
-		httpClient := http.DefaultClient
+		httpClient := tracing.NewHTTPClient()
 		ecosystemsClient, err := ecosystems.NewClientWithResponses(ecosystems.BaseURL, ecosystems.WithHTTPClient(httpClient))
 		if err != nil {
 			cobra.CheckErr(fmt.Errorf("failed to construct API client for Ecosyste.ms' Packages API: %w", err))

cmd/dmd/cmd/report_hacktoberfest.go

@@ -2,7 +2,6 @@ package cmd
 
 import (
 	"fmt"
-	"net/http"
 	"os"
 
 	"dmd.tanna.dev/internal/domain"
@@ -61,7 +60,7 @@ If a GITHUB_TOKEN is not provided, we will use the cached data in Ecosystems, wh
 			},
 		}
 
-		tw, err := reports.Hacktoberfest(ctx, logger, sqlDB, pw, http.DefaultClient, githubToken, params)
+		tw, err := reports.Hacktoberfest(ctx, logger, sqlDB, pw, tracing.NewHTTPClient(), githubToken, params)
 		cobra.CheckErr(err)
 
 		if tw == nil {

go.mod

@@ -26,6 +26,7 @@ require (
 	github.com/xanzy/go-gitlab v0.106.0
 	gitlab.com/tanna.dev/cobra-doc-template v0.0.0-20231221133114-8f5f0e77db94
 	gitlab.com/tanna.dev/endoflife-checker v0.7.0
+	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.53.0
 	go.opentelemetry.io/otel v1.32.0
 	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.32.0
 	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.32.0
@@ -58,6 +59,7 @@ require (
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
 	github.com/charmbracelet/lipgloss v0.10.0 // indirect
 	github.com/dustin/go-humanize v1.0.1 // indirect
+	github.com/felixge/httpsnoop v1.0.4 // indirect
 	github.com/go-ini/ini v1.67.0 // indirect
 	github.com/go-logfmt/logfmt v0.6.0 // indirect
 	github.com/go-logr/logr v1.4.2 // indirect

internal/tracing/http.go

+package tracing
+
+import (
+	"net/http"
+
+	"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
+)
+
+func NewHTTPClient() *http.Client {
+	return &http.Client{
+		Transport: otelhttp.NewTransport(http.DefaultTransport),
+	}
+}