Skip to content
Snippets Groups Projects
Select Git revision
  • main default protected
  • ignore-TestPowershell_GetConfiguration-for-all-windows
  • fix-generate-artifacts-metadata-BuildFinishedOn
  • fix-trigger-ubi-images-security-main
  • docs-link-fix
  • ajwalker/new-masking
  • image-pull-policy-for-services
  • dnldnz-parse-tmpdir-path
  • support-image-pull-policy
  • multi-line-command-uncollapsed
  • configure_helper_registry
  • 27853-improve-trace-with-buffered-writes
  • DarwinJS-powershell-information-update
  • k8s-helper-entrypoint-logic
  • k8s-large-configmap-resource
  • dwainaina-docs-add-feature-flag
  • 15-0-stable
  • 21h1-test-machine-idle-limits-failure
  • update-git-lfs-to-2-13-3
  • 21h1-merge-failures
  • v15.0.0
  • v14.8.3
  • v14.10.1
  • v14.9.2
  • v14.10.0
  • v14.9.1
  • v14.9.0
  • v14.8.2
  • v14.7.1
  • v14.6.1
  • v14.8.1
  • v14.8.0
  • v14.7.0
  • v14.6.0
  • v14.6.0-rc1
  • v14.3.4
  • v14.4.2
  • v14.5.2
  • v14.3.3
  • v14.4.1
40 results

shells

  • Clone with SSH
  • Clone with HTTPS
  • Forked from GitLab.org / gitlab-runner
    10997 commits behind, 2 commits ahead of the upstream repository.
    Tomasz Maczukin's avatar
    Tomasz Maczukin authored
    Fix {Bash,Cmd,Ps}Writer.IfCmd to escape its arguments
    
    ## What does this MR do?
    
    Refactors the shell writers to use the same escaping logic in their `Command()` and `IfCmd()` methods
    
    ## Why was this MR needed?
    
    !359 started using `IfCmd` with URLs as arguments. URLs include various characters that need escaping, especially `&` in bash.
    
    ## Are there points in the code the reviewer needs to double check?
    
    The powershell and cmd changes look sane, but I haven't managed to run the executors/shell tests. Although I don't think they exercise the cache path anyway.
    
    ## Does this MR meet the acceptance criteria?
    
    - [ ] Documentation created/updated
    - Tests
      - [ ] Added for this feature/bug
      - [ ] All builds are passing
    - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
    
    ## What are the relevant issue numbers?
    
    Closes #1820 
    
    /cc @ayufan @tmaczukin @stanhu
    
    See merge request !364
    6574a6c9
    History