Cache not downloaded/uploaded due to "unquoted" URL
Summary
Runner-Cache not being downloaded/uploaded due to malformed / unquoted URL in HTTP request for Cache.
Steps to reproduce
Install, configure & use S3 / minio as Runner-Cache
Set some Caching in .gitlab-ci.yml (mine looks like the following):
cache:
key: "$CI_BUILD_STAGE"
paths:
- node_modules/
Verify the Cache is acutually being used by Runner 1.6.x.
Update from GitLab CI Multi Runner 1.6.x to 1.7.0
See if it breaks.
Actual behavior
The URL built seems not to be quoted, thus Bash is interpreting Query-String Parameters as single Commands.
Expected behavior
The Cache should be downloaded/uploaded properly.
Relevant logs and/or screenshots
GitLab Runner 1.7.0
Checking out e66dd8e1 as master...
Checking cache for deploy_prod...
/bin/bash: line 76: X-Amz-Credential=[REDACTED]%2F20161023%2Fus-east-1%2Fs3%2Faws4_request: command not found/bin/bash: line 76:
X-Amz-Date=20161023T152710Z: command not found
/bin/bash: line 76: X-Amz-Expires=3600: command not found
/bin/bash: line 76: X-Amz-SignedHeaders=host: command not found
Failed to extract cache
the same happens while trying to upload a new cache.zip:
Creating cache deploy_prod...
/bin/bash: line 54: X-Amz-Credential=[REDACTED]%2F20161023%2Fus-east-1%2Fs3%2Faws4_request: command not found
/bin/bash: line 54: X-Amz-Date=20161023T152840Z: command not found
/bin/bash: line 54: X-Amz-SignedHeaders=host: command not found
/bin/bash: line 54: X-Amz-Expires=3600: command not found
Failed to create cache
GitLab Runner 1.6.x (same Project)
Checking out f56689c0 as master...
Checking cache for deploy_prod...
Downloading cache.zip from https://[REDACTED]/gitlab-runner/runner/[REDACTED]/project/42/deploy_prod
$ eval $(ssh-agent -s)
Environment description
We're using GitLab 8.14.0-ee Omnibus Installation, GitLab CI Multi Runner 1.7.0 on Docker 1.12.2 and minio/minio:RELEASE.2016-10-07T01-16-39Z as a Amazon S3 compatible Cache Backend.
Used GitLab Runner version
Version: 1.7.0
Git revision: c66b00d
Git branch: 1-7-stable
GO version: go1.7.3
Built: Fri, 21 Oct 2016 21:30:34 +0000
OS/Arch: linux/amd64