Fixed Solarus Assertions
So merge !1395 (merged) didn't quite go as planned (described in #1549 (closed)) and this merge simply fixed the primary issue caused by that merge while maintaining its advantages. The core/Debug.h
introduces SOLARUS_REQUIRE
. Changes in other files are simply replacing any uses of SOLARUS_ASSERT
that used to be Debug::check_assertion
with SOLARUS_REQUIRE
. I believe I have changed every instance of that -- although proving that is left as an exercise -- with there being less changes over all because the tests were fine and I didn't do any error reformatting.