Update Soluars Assertions
This changes SOLARUS_ASSERT
to not rely on Debug::check_assertion
, replaces all calls of check_assertion
with uses of SOLARUS_ASSERT
and removes check_assertion
.
The new macro has a slight performance improvement if the assertion passes. Using the macro in all cases means that all assertions are debug mode only. A second macro for release mode assertions could be added if we need it.
(If you are reviewing, the interesting stuff is in core/Debug.h.)