Skip to content

libcli/http: Handle http chunked transfer

Noel Power requested to merge samba-team/devel/samba:npower_http_chunked into master

at least latest elasticsearch version elasticsearch-8.12.2-1.x86_64 (and maybe earlier version(s)) break spotlight (and wip WSP server) code by transferring responses back to the client using 'chunked transfer encoding' indicated by http header "Transfer-encoding: chunked'

this patch support chunking (in a basic enough way) but works

no test yet (not sure if possibly to easily test from selftest) have manually tested against the above elasticsearch version (and earlier one that doesn't use 'chunked encoding')

adding you guys to keep you in the loop @slowfranklin for obvious reasons and @scabrero as author of the http stuff

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports