Skip to content

Draft: GetNCChanges from metze towards correct sub-NC replication

Andrew Bartlett requested to merge samba-team/devel/samba:abartlet/metze-getncchanges-wip into master

These are the patches pointed at by @metze in https://lists.samba.org/archive/samba-technical/2023-June/138274.html for replication spinning but are actually more to do with correctly representing sub-partitions during the replication cycle.

Draft MR created here as I have rebased on master. some tests currently fail:

failure: samba4.drs.ridalloc_exop.python(vampire_dc).ridalloc_exop.DrsReplicaSyncTestCase.test_edit_rid_master(vampire_dc) [
failure: samba4.drs.fsmo.python(vampire_dc).fsmo.DrsFsmoTestCase.test_InfrastructureMasterTransfer(vampire_dc) [
failure: samba4.drs.fsmo.python(vampire_dc).fsmo.DrsFsmoTestCase.test_NamingMasterTransfer(vampire_dc) [
failure: samba4.drs.fsmo.python(vampire_dc).fsmo.DrsFsmoTestCase.test_RIDMasterTransfer(vampire_dc) [

Based on !3143 (closed)

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Andrew Bartlett

Merge request reports