Skip to content

Azure AD Connect GetNCChanges compatability

Andrew Bartlett requested to merge samba-team/devel/samba:abartlet/repl-state-handling into master

An earlier version of this patch has been successfully tested with Azure AD Connect directly.

A fix for the current blocker issues seen on larger Samba domains that sync with Azure AD using the Azure AD Connect sync tool.

Even if this is not the full fix for all issues (and it is known that there are still issues with the other tool, Azure AD Cloud connect), it does improve correctness and has been tested on a problematic domain and shown to work.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15401

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • (optional) This MR is just one part towards a larger feature.
  • (optional, if backport required) Bugzilla bug filed and BUG: tag added
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated
  • CI timeout is 3h or higher (see Settings/CICD/General pipelines/ Timeout)

Reviewer's checklist:

  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to README.Coding.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Andrew Bartlett

Merge request reports