postmarketos-release-upgrade reboot prompt is way too easy to trigger accidentally
Describe your issue
postmarketos-release-upgrade reboot prompt is way too easy to trigger accidentally, e.g. in my case by pressing enter because the terminal has a bug where scrolling down via touch won't make it "stick" to the bottom and scroll with new output again, while pressing enter will. But such a spurious enter press that can be as extreme as half an hour ago will still immediately trigger a reboot at the end, which with something like #1857 can be a disastrous idea
What's the expected behaviour?
The reboot prompt requires entering 'yes' or 'no' to advance, not something as easy to accidentally trigger like enter. Alternatively, it should discard all key presses from before the prompt even shows
What's the current behaviour?
A spurious enter from forever ago will still go into a reboot
How to reproduce your issue?
Start upgrade, press enter. At the end of the upgrade it will reboot without asking you
What device are you using?
PinePhone Allwinner 3GB RAM variant
On what postmarketOS version did you encounter the issue?
-
edge ( master
branch) -
v22.06
-
v22.12
-
I confirm that the issue still is present after running sudo apk upgrade -a
On what environment did you encounter the issue?
Environments
-
Phosh -
Plasma Mobile -
Sxmo (Wayland/Sway) Please post the output of sxmo_version.sh
-
Other: Please fill out
How did you get postmarketOS image?
-
from https://images.postmarketos.org -
I built it using pmbootstrap -
It was preinstalled on my device