postmarketos-release-upgrade suspicious behavior: prompt user to retry if apk fix (or other worthwhile retries) not successful
Describe your issue
I'm seeing weird behavior from postmarketos-release-upgrade: it seems like a corrupted package is not retried, but it also doesnt stop and just carries on like nothing happened:
Unless I'm interpreting the output wrong, this behavior seems like a recipe for a corrupted, critically broken upgrade result without a very eagle-eyed user spotting this and using apk fix before rebooting. It would be nice if instead the script somehow tried to fix this instead, since it seems to be caused by a network error.
What's the expected behaviour?
corrupted packages are retried
What's the current behaviour?
corrupted packages appear to be ignored even when they didn't upgrade/install at all, even if it was just a network hiccup
How to reproduce your issue?
use shaky internet during upgrade
What device are you using?
Allwinner PinePhone 3GB variant
On what postmarketOS version did you encounter the issue?
-
edge ( master
branch) -
v22.06
-
v22.12
-
I confirm that the issue still is present after running sudo apk upgrade -a
On what environment did you encounter the issue?
Environments
-
Phosh -
Plasma Mobile -
Sxmo (Wayland/Sway) Please post the output of sxmo_version.sh
-
Other: Please fill out
How did you get postmarketOS image?
-
from https://images.postmarketos.org -
I built it using pmbootstrap -
It was preinstalled on my device