Block size of ISBlock cannot be causually changed; otherwise completely...

Block size of ISBlock cannot be causually changed; otherwise completely changes the meaning of the IS indices

$ ./ex3 0: 2 3 14 15 18 19 0: 3 4 5 21 22 23

Commit-type: error-checking, bug-fix

@jedbrown @prj- @wence @stefanozampini

changed milestone to %v3.12.1

added bug workflowReview labels

resolved all threads

added 1 commit

• 717325b3 - Apply suggestion to src/vec/is/is/impls/block/block.c

Compare with previous version

@prj- @jedbrown @stefanozampini please check and approve this trivial new error checking

mentioned in issue #360 (closed)

added 28 commits

• 717325b3...31d8d3ac - 26 commits from branch maint
• 5d6eab99 - Block size of ISBlock cannot be causually changed; otherwise completely...
• 7ec28472 - Apply suggestion to src/vec/is/is/impls/block/block.c

Compare with previous version

I've rebased this branch over latest maint and started a new test pipeline.

@BarrySmith you might want to recreate this branch - before any additional changes

resolved all threads

https://gitlab.com/petsc/petsc/-/jobs/329355068

not ok diff-vec_is_tests-ex3_2 # Error code: 1
#	1c1
#	< [0]PETSC ERROR: Object is in wrong state
#	---
#	> [0]PETSC ERROR: Object is in wrong state

added 1 commit

• 887b172f - Test should check stderr for PETSc error message

Compare with previous version

not ok diff-vec_is_tests-ex3_2 # Error code: 1

1c1

< [0]PETSC ERROR: Object is in wrong state

---

> [0]PETSC ERROR: Object is in wrong state

@krugers Ok, I don't understand this. Could it be a carriage return or something that produces the diff? Anyways I tried added Error: to see if it is somehow related to stderr output. Perhaps something changed in handling of different types of error output (stdout vs stderr) with the recent changes? It runs fine on my machine both with and without the Error: so ?

changed milestone to %v3.13-maint

mentioned in merge request !2175 (merged)

Error: did not fix this https://gitlab.com/petsc/petsc/-/jobs/329415279

I am happy with this error checking, but can't approve for some reason.

resolved all threads

added 229 commits

• 887b172f...96e55a2f - 226 commits from branch maint
• cb02163f - Block size of ISBlock cannot be causually changed; otherwise completely...
• bca5c82f - Apply suggestion to src/vec/is/is/impls/block/block.c
• 46412508 - Test should check stderr for PETSc error message

Compare with previous version

added 1 commit

• 06364481 - On some test boxes isatty() says yes hence strange characters are saved into...

Compare with previous version

approved this merge request

assigned to @sbalay and unassigned @BarrySmith

added workflowReady-For-Merge label and removed workflowReview label

merged

mentioned in commit 5fba5200