Skip to content
Snippets Groups Projects

slepc: use commit-id not branch-name as branches get deleted

Merged Satish Balay requested to merge balay/fix-slepc into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Satish Balay approved this merge request

    approved this merge request

  • merged

  • Satish Balay mentioned in commit 75d136db

    mentioned in commit 75d136db

    • Sorry, this why my mistake, I had assumed that when the code got merged into master the corresponding SLEPc MR would be get merged into its master and you would change my branch name to that final commit in SLEPc. When this kind of change happens in the future I will make a full note with a thread in the MR about what needs to be coordinated when merging the MR.

    • I think its better to use commit-id [instead of branch name] in the petsc MR. Both modes have positives and negatives..

      When you had a branch-name [in the MR] - I was supposed to have fixed it before merging [Ishould have added a review-comment - so that this wasn't skipped]

      Note: this scheme will work as long as the SLEPc MR branch is not rebased (or collapsed etc..) after the PETSc MR is merged.

    • Please register or sign in to reply
Please register or sign in to reply
Loading