Post-Release Clean up through August 9

This is the consolidated list of priority bug fixes after the Release testing by Dan and Greg On Sat/Sun August 3/4. Previous work lists should be ignored - this replace them. Once these items are addressed (target - August 9th), we'll either 1) make a new list of priority bug fixes or 2) return to the sprints with feature needs (like rights and roles) or lower-priority fixes.

Testing setup

Reference to testing setup Tested on phone and computer, chrome.

End of August Priority

  • ⭐ 🐛 Finish up existing work with pinned surveys + offline availability. !438 (merged)

    • (additional information) Offline behavior is not working correctly. Full description here, it's failing in a variety of ways that needs to be investigated. Connect with @DanTerAvest to repeat and review #357 (closed). This is critical priority, but because the largest impact is on CRS which won't start for at least a week, if this needs to get wrapped into 2nd week's bug fixes that's ok. If we need to re-work specifications that's also ok, but what's critical is that what we say the app does, it always does and it does it correctly every time. And what we say it doesn't do, it doesn't do.
      • ❓ This is important buy maybe addressed. Once the other fixes are in place (especially deployed fixes for pinned surveys and draft saving offline) then I think we can re-evaluate this - possibly there's no additional work needed.

  • ⭐ 🐛 On mobile, when you press the back button to show the navigation while in a submission, the ConfirmLeaveDialog does only appear after choosing a different route in the navigation. see details in comment #355 (comment 2059481685) ESTIMATION 0.5 hour !440 (merged)

  • ⭐ 🐛 On mobile, when you exit a "start as member" response, you are not prompted with the "warning we don't save proxy drafts", so the user could easily lose their draft without knowing it. This is a critical failure. !440 (merged)

    • If the right answer on this is a broader work package that can't be addressed in a week or two, then let's wrap this into a separate issue to work on later.
    • @gbathree did you change the route? probably, the prompt will show up then. I assume this is the same root cause like the exit confirmation which also appears only after a route change, so going back to navigation and then choosing an item
  1. ⭐ 🐛 If you add a member, and later confirm with "Confirm Membership" button in Members list, it clicks into the members "Edit Membership" page rather than confirming. This appears to be an issue with the button being behind the click for the row item. I believe we already identified this before and fixed it... maybe somehow this didn't get merged in or something? This may be something you'll want to check elsewhere in the app also in case it's a broader issue overlaying clickable content on lists. PS same happens when clicking on 'Invite to Hylo' ESTIMATION 1 hour
  • 🐛 --> response draft appearance on mobile, see #352 (closed)
  1. ⭐ 🐛 Survey drafts not marked draft when Publish without Save first: #351 (closed) (updated issue w/ recommendation on how to address it quickly). ESTIMATION 0.5 hour
  2. ⭐ 🐛 If you are a Member or Visitor, you see the option to "Start Survey as Member". This doesn't work (when you try to submit it says you can't) but the option should not be available in the dropdown. This applies to 3 dots in sidebar and in All Surveys list. ESTIMATION 1 hour
  3. go to group -> settings -> subgroups, and click on a subgroup. On desktop this sends you to the the group sidebar page rather than landing on the Group Responses page. This should land on the Group Responses page. I also think, given the number of locations we have to manage this issue and the very high chance we'll change that default landing page in the future, we should have a standard pointer for the location of that 'default' landing page which is updated one place to apply everywhere. The mobile rules will be different - defaulting to the sidebar menu in that 'default' state instead ESTIMATION 1 hour
  4. ⭐ 🐛 If a user has a single group, they automatically start in that group when logging in (bypassing the All Groups screen). This is fine, however, on desktop they are starting on the sidebar-focus screen rather than the standard Group Responses screen. You can use greg+single_user@our-sci.net as example login. ESTIMATION 1 hour

Priority 1

  1. ⭐ 🐛 Return super admin user and apply to dan / greg ASAP. We'll be unable to effectively support partners if issues appear if we don't have this role, so it's priority number one. !432 (merged)
  2. ⭐ 🐛 There are still failures in the FarmOS Admin interface. OpenTEAM shows the following error in the console when logged in as gbathree and going to -> Super Admin -> FarmOS -> Groups -> OpenTEAM (see below). FarmOS -> Groups -> Pasa will load w/ farmOS instances listed, but group Our-Sci will not load. Please connect / work with @gbathree or @DanTerAvest to confirm and repeat the problem. We need this to support partners, so it's priority. !428 (merged) @desousab
  3. ⭐ 🐛 There's an issue with formatting in results page #354 (closed)
  4. ⭐ When you submit a survey, you are provided a screen saying "Confirm Submission" and "Submit this draft to..." with the name of the group. Users may change the submission group route at this point, which in the new structure should not be possible. We need to remove this option so users cannot change the route on submission. However, we should retain the confirmation message saying "Submit this draft to ?". In the future, especially with rights and roles, we'll probably further improve this screen, but for now remove the option to change group and make it an informative message only. !435 (merged) @desousab
  5. ⭐ 🍰 The custom documentation links are still under the "Learn SurveyStack" section, but we really need that to be in a separate section. I believe we had a separate issue that described that fix, but definitely we should fix this ASAP.
    • In addition, newly added documentation doesn't appear until you hard refresh the page. Ideally, this should appear after adding... so I would consider refreshing the page after a user adds new documentation so it shows up (that's helpful for the user to see the change... otherwise they changed something but it didn't appear to work). See item below "When you save in group -> settings, there's no confirmation" for potentially related issue and solution.
    • #359 (closed) @manuel-ch

Priority 2

  • ⭐ 🍰 on mobile there is now an Unpin option, but on desktop there is no Unpin option. Please add Unpin also to desktop for sidebar pinned survey.

Pushing off to other issues / bugs

  • pin and unpin survey is too slow ! adapt api.put(/groups/${group._id}, group) for togglePinSurvey function

  • potentially related issues / solutions:

    • modify the current behavior of archiving a group, based on your review to close the MR 428: when we archive a parent group, all children groups should also be archived
    • When you archive a group, the top left nav bar is not updated until you fully refresh the page.
    • When you save in group -> settings, there's no confirmation. Also, nothing reloads. I would expect both a confirmation, and a reload. This may also address the issue that top left nav bar doesn't update to hide newly archived surveys if you reload after save.

  • ⭐ 🐛 As a "Visitor" (logged in or not logged in) to a group, the Pinned surveys are not appearing in the sidebar when online. "Member" and "Admin" roles show Pinned surveys correctly in the sidebar. !431 (merged)

  • Include a start survey link the 3 dot menu.

  • farmOS page has a weird layout, with the trim grey background. Could we have it have the same background as the other pages? We can also slightly widen the size of the content as well.

for the future

  • ⭐ 🐛 Question sets not controlled by the group still have an Edit option. They should not have an edit option. This is an issue we'll deal with when we get to rights and roles... but it will create a lot of confusion if we don't engage this now. @desousab On August 30, editing a QS is based on the right & role 'Right to Edit' == is group Admin. But the problem is that all QS are listed in all groups.
  • feature delete survey. Given Rights and Roles will be next on our list of things to do... what will we need to consider re. archiving and deleting in a 'rights and roles' surveystack world, esp. given previous comments and concerns? #215 (comment 1313510183) and we did a lot of work on this here: #215 (comment 1313510183)
Edited by Benoît DE SOUSA