Incorrect kihop calculations when multiple clients of the same master account are involved
Summary
Kihop gives 10% extra damage to taekwon/star gladiator for every other member of the party in the same map. In oRO, only players that are not dual-clienting will be counted. There are two issues: it does not give bonus if the dual-clienter is the taekwon (and the taekwon does not count itself for the calculation in a normal scenario) and the bonus does not return even if the player stops dual clienting, for an undefined period of time.
Steps to Reproduce
- With someone in your party (no dual clients), attack something.
- Expel a person from the party, the damage goes down as expected.
-
Invite the person again to the party, damage goes up.
-
Invite another one of your characters (dual client).
-
See expected result A.
-
Expel the dual client. Additionally, you can also exit with that client.
- See expected result B.
Actual result
A. Damage gets reduced as if you didn't have any bonus.
B. Damage is still reduced as if you didn't have any bonus.
Expected result
A. Bonus should be counting at least the non-dual-clienting player.
B. Bonus should return to 10% (one party member besides the taek).
Additional Information
As seen in this changelog,
Skills: Stopped counting dual-clients for Kihop bonus. Only players that are not dual-clienting will be counted now. Related to #2623 (closed) [c462d1b733] The main actor here (taekwon, star gladiator) should be able to dual-client without issue.
Character Information
Star gladiator, no buffs, no weapon, just kihop 5 and party members.