Skip to content

[STAR-2877, STAR-2879, STAR-2880] Several fixes to checklist presentation

Fox Piacenti requested to merge fox/listing-tweaks into master

Fixes several issues with the presentation of checklists. Namely:

  1. The 'Response' column now shows how many people have responded. To avoid confusion, nothing is displayed for one-offs. Side bonus: The listing is even faster now!
  2. Focus, hover, and active states are implemented on checklist listings
  3. The entire checklist entry is clickable, with the correct cursor type, without preventing the existing interactive elements from being used
  4. Subjects in emails no longer get mangled if they have an ampersand

Supporting information

Visual changes

https://www.loom.com/share/9ebafbfe7f5a450cab5eaecb1dd515f8

Testing instructions

Step by step procedure

  1. Check out this branch
  2. Undo the changes to the email subject templates and run the tests. They should fail.
  3. Re-apply the changes and rerun the tests. They should succeed.
  4. Run the frontend and verify that the different modes, hover, focus, and active, work as expected and match the design.
  5. Verify that the checklist is clickable aside from the interactive elements.
  6. Check that the Response column is now showing how many people completed their checklist rather than how many tasks are in the entire run

Merge request reports