Draft: [BB-8204] feat: Detect Collapsed Items in Checklists
Short description on what are changed/implemented in this pull request
Supporting information
- Jira ticket: BB-8204
- GitLab issue: #117 (closed)
Discussions
Link to any public discussions about this PR or the design/architecture. Otherwise omit this.
Dependencies
None or link it here.
Visual changes
Merge deadline
None
Testing instructions
Step by step procedure
- Checkout to this branch
- Start the Listaflow docker
- Start the front-end development server
- Log in with
admin@example.com
- Create a new list using
Ghost White
template - Don't fill any required items and try to submit the form
- You should be scrolled to the first required item needed to submit
- All the missing required items should have the error message flagging it
Author notes and concerns
I have a couple of questions of weird behaviors with the current implementation,
- The subtasks inside a checklist isn't propagating a change to the
taskController
, which creates multiple side effects including:
- The progress bar doesn't update
- The error message will not dissapear
- The main controller of the checklist doesn't report that the taskItem is completed
For this issue I checked out the states of all the controllers and found out that the cc
controllers are updating correctly, but they are not synchronized with the main taskController
meaning that we are loosing the reference of each child controller when useList
is used to create the list of all the subtasks. At the end, it is never entering the useEffect that updates all controllers correctly and that's why none of the other elements in the page are updating correctly. I'm not sure what is the best approach to fix this, but once that is synchronized everything should be working as expected...
- Once the error messages appear, the user will not be able to submit the form. What is the expected behavior for this?