Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
openbravo
openbravo
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Custom Issue Tracker
    • Custom Issue Tracker
  • Labels
  • Merge Requests 9
    • Merge Requests 9
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Commits
  • openbravo
  • product
  • openbravoopenbravo
  • Merge Requests
  • !228

Open
Opened Nov 12, 2020 by Cristian Berner@cristian.berner💎Developer
  • Report abuse
Report abuse

Draft: Fixes ISSUE-45436: JsonToDataConverter is appending parameters to hql wrongly

  • Overview 1
  • Commits 1
  • Changes 1

In method getBaseOBObjectFromId some parameters were appended directly to the hql where clause, to avoid this, it has been converted to OBCriteria.

Test plan

It can be tested with the following tests:

  • JsonConversionTest
  • DataQueryServiceTest
  • ComputedColumnsTest#testJSONConverter
Edited Nov 16, 2020 by Cristian Berner
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: openbravo/product/openbravo!228
Source branch: fix/45436-jsontodata