Reduce use of MAX_DIM macro
Description
Some changes to reduce the use of the MAX_DIM macro in the code. Mainly it changes the the size to which the mesh%x array is allocated along the second dimension (it was MAX_DIM and now it is mesh%sb%dim). As a side effect the mesh_x_global function now returns an vector of size mesh%sb%dim instead of MAX_DIM and the coords optional argument of function mesh_r now works for vectors that are not of size MAX_DIM.
This MR was originally part of !1169 (merged), but in the end, although useful, it ended up in not being necessary for the changes in that other MR.
News snippet
Some changes to reduce the use of the MAX_DIM macro in the code.
Checklist
-
I have checked that my code follows the Octopus coding standards -
I have added tests for all the new features added in this request.
Merge request reports
Activity
changed milestone to %11.0
added Refactoring label
Codecov Report
Merging #1174 (1e5939cc) into develop (fc9346d0) will increase coverage by
0.00%. The diff coverage is73.19%.
@@ Coverage Diff @@ ## develop #1174 +/- ## ======================================== Coverage 70.40% 70.40% ======================================== Files 513 513 Lines 102499 102497 -2 ======================================== Hits 72164 72164 + Misses 30335 30333 -2Impacted Files Coverage Δ src/grid/curvilinear.F90 73.80% <ø> (ø)src/maxwell/maxwell_boundary_op.F90 71.78% <0.00%> (ø)src/maxwell/propagator_mxll.F90 61.91% <0.00%> (ø)src/output/output_me_inc.F90 28.83% <0.00%> (+1.18%)
src/td/td_write.F90 55.31% <0.00%> (ø)src/grid/mesh.F90 73.00% <40.00%> (-0.15%)
src/opt_control/initst.F90 36.36% <50.00%> (ø)src/poisson/poisson_corrections.F90 74.30% <50.00%> (-0.35%)src/hamiltonian/kick.F90 64.56% <57.14%> (+0.06%)src/td/pes_mask.F90 55.26% <57.14%> (ø)... and 21 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update fc9346d...1e5939c. Read the comment docs.Edited by Codecovadded 1 commit
- 1e5939cc - Change mesh_r function such that the optional argument coords is always of...
mentioned in commit 66cece61
