Skip to content

[Chore] Remove refilling loop from test scenarios

Pinto Pasquale requested to merge pasqu4le/chore-refill-tests-once into master

Description

Problem: we currently try to keep dedicated moneybag addresses with sufficient funds by refilling them in a loop concurrent with the scenario that uses it. This turned out to be problematic and not very robust, so we want to avoid it after all.

Solution: remove the refilling loop and instead only refill once before the scenario starts. To avoid too many funds from getting stuck in temporary moneybags, most funds get also transferred back after the scenario has completed. Additionally, the refill-balance has been updated in all scenarios to be big enough and with some margin.

Related issue(s)

None, but supersedes !1119 (closed)

Checklist for your Merge Request

Related changes (conditional)

  • Tests (see short guidelines)

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog files of all affected packages released to Hackage if my changes are externally visible.

Stylistic guide (mandatory)

Edited by Pinto Pasquale

Merge request reports